update the doc for how to write the operators. #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lcy-seso
commented
Sep 5, 2017
•
lcy-seso
commented
- 之前部分代码段没有设置格式，所以没有启用高亮。
- 编译方式发生变化。
- CMakeLists.txt 一部分是按照 *_op.cc 这样的命名方式来添加源码，按照自己理解修改了一些。
luotao1
reviewed
Sep 5, 2017
doc/howto/dev/new_op_cn.md
Outdated
|
|
||
| 下面命令可以编译： | ||
|
|
||
| 无需修改[paddle/operators/CMakeLists.txt](/~https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/CMakeLists.txt)文件，`paddle/operators` 目录下新增的 `*_op.cc` 文件会被自动加入编译。 |
There was a problem hiding this comment.
如果是DEPS的op，需要改cmakelists.txt。不过cmake这块还在修改和完善，这里先这样写着也可以。或者说明一下：没有DEPS的op自动加入编译。
qingqing01
reviewed
Sep 5, 2017
doc/howto/dev/new_op_cn.md
Outdated
| @@ -310,7 +297,7 @@ class TestMulOp(unittest.TestCase): | |||
| - 第四个参数`"Out"` : 指定前向网络最终的输出目标变量`Out` | |||
|
|
|||
|
|
|||
| ### 编译和执行 | |||
| ### 编译和执行 | |||
There was a problem hiding this comment.
下面308行，能否帮忙改成：
编译时需要打开WITH_TESTING, 即 cmake paddle_dir -DWITH_TESTING=ON，请注意，运行单测时的需要编译整个工程，不同于上述Op的编译测试，编译成功之后执行单测命令为：
主要是为了和Op里的编译测试区分开，上述Op里编译，可以只编译单独的一个文件，方便测试。 这里Python测试需要生成core.so，需要编译整个工程。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.